This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
Synchronize changes from vscode-graphql/pull/215 #937
Draft
phryneas
wants to merge
6
commits into
main
Choose a base branch
from
pr/sync-editor-plugins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-monodocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
phryneas
changed the title
Synchronize changes from https://github.com/apollographql/vscode-graphql/pull/215
Synchronize changes from vscode-graphql/pull/215
Sep 23, 2024
@Meschreiber this is the synchronization of those README changes - can I just ignore those lint messages or do I have to whitelist them somehow? |
Side-by-side preview/comparison with current docs here, I'm still adjusting the styling a bit |
prismjs supports comments in json
@phryneas always feel free to ignore! I'll fix the whitelisting separately. |
Meschreiber
approved these changes
Sep 23, 2024
Converted this PR to a draft so it's not merged too soon by accident, but it's ready to go from my side. |
This was referenced Sep 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronize changes from apollographql/vscode-graphql#215